Skip to content

chore: add bigquery-jdbc backlog from commit history#13251

Open
logachev wants to merge 1 commit into
mainfrom
kirl/jdbc_changelog
Open

chore: add bigquery-jdbc backlog from commit history#13251
logachev wants to merge 1 commit into
mainfrom
kirl/jdbc_changelog

Conversation

@logachev
Copy link
Copy Markdown
Contributor

Using jetski to re-create changelog for already released versions. Will be updated by the bot moving forward

@logachev logachev marked this pull request as ready for review May 22, 2026 05:47
@logachev logachev requested a review from a team as a code owner May 22, 2026 05:47
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive CHANGELOG.md for the BigQuery JDBC driver, documenting the project's history from version 0.1.0 to 0.10.0. Feedback was provided to improve the consistency of the document by normalizing component scopes to a single format and ensuring that all entry descriptions use the imperative mood.

Comment on lines +47 to +48
* chore(jdbc bq): makefile commands to run standalone IT tests (#12666) ([91eb471](https://github.com/googleapis/google-cloud-java/commit/91eb471c21d687e09f7505997d6220f9480eb5da))
* chore(bq jdbc): change uber jar bundling rules (#12195) ([ed0ac75](https://github.com/googleapis/google-cloud-java/commit/ed0ac7548078c8d16f2386e0645d73c1ba8bd995))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The component scopes are inconsistent even within the same version block (e.g., jdbc bq vs bq jdbc). Throughout the file, variations like bqjdbc, bq jdbc, jdbc bq, and jdbc are used. Normalizing these to a single consistent scope (such as bqjdbc, which is used in the most recent entries) would improve the readability and professional quality of the changelog.

Suggested change
* chore(jdbc bq): makefile commands to run standalone IT tests (#12666) ([91eb471](https://github.com/googleapis/google-cloud-java/commit/91eb471c21d687e09f7505997d6220f9480eb5da))
* chore(bq jdbc): change uber jar bundling rules (#12195) ([ed0ac75](https://github.com/googleapis/google-cloud-java/commit/ed0ac7548078c8d16f2386e0645d73c1ba8bd995))
* chore(bqjdbc): makefile commands to run standalone IT tests (#12666) ([91eb471](https://github.com/googleapis/google-cloud-java/commit/91eb471c21d687e09f7505997d6220f9480eb5da))
* chore(bqjdbc): change uber jar bundling rules (#12195) ([ed0ac75](https://github.com/googleapis/google-cloud-java/commit/ed0ac7548078c8d16f2386e0645d73c1ba8bd995))

### Refactors & Chores

* chore: move Google JDBC driver code (#4050) ([c3a1b78](https://github.com/googleapis/google-cloud-java/commit/c3a1b787e63c6e75805956f9abca8d93186424ab))
* chore(jdbc): moving helper scripts & simplify dependencies (#4062) ([e9bc501](https://github.com/googleapis/google-cloud-java/commit/e9bc501db0403e1cd293f74c98867b04ed2b0b24))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description for this entry uses inconsistent verb tenses ('moving' vs 'simplify'). It should be normalized to use the imperative mood ('move' and 'simplify') to match the style of other entries in the changelog.

Suggested change
* chore(jdbc): moving helper scripts & simplify dependencies (#4062) ([e9bc501](https://github.com/googleapis/google-cloud-java/commit/e9bc501db0403e1cd293f74c98867b04ed2b0b24))
* chore(jdbc): move helper scripts & simplify dependencies (#4062) ([e9bc501](https://github.com/googleapis/google-cloud-java/commit/e9bc501db0403e1cd293f74c98867b04ed2b0b24))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant