fix(bqjdbc): resolve JDBC metadata compliance gaps for wrappers, searchability, and type mappings#13242
Merged
Conversation
…chability, and type mappings
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the type mapping logic in BigQueryDatabaseMetaData by introducing a static STANDARD_TYPE_INFO map and updates several BigQuery-to-JDBC type mappings, such as changing the default string representation to NVARCHAR and mapping complex types like GEOGRAPHY and JSON to Types.OTHER. Additionally, it implements the unwrap and isWrapperFor methods in BigQueryDatabaseMetaData, BigQueryResultSetMetadata, and the JDBC context proxy to support standard JDBC wrapper operations. Corresponding unit tests have been updated and expanded to verify these changes. I have no feedback to provide as there were no review comments to assess.
logachev
reviewed
May 20, 2026
logachev
approved these changes
May 21, 2026
keshavdandeva
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/514445832
Key Changes
DatabaseMetaData.getColumns()type resolution (viamapBigQueryTypeToJdbc) to map BigQuery types and database-specific type names compliantly (e.g.,STRING,RANGE,GEOGRAPHY,JSON,INTERVAL).StandardSQLTypeName.STRINGmaps toTypes.NVARCHARto support Unicode/UTF-8 string reporting).Types.NVARCHAR/STRINGinstead ofTypes.VARCHARto keep mapping behavior consistent across the driver.StandardSQLTypeName.STRINGtoTypes.NVARCHAR(UTF-8 character encoding reporting).unwrapandisWrapperFor) inBigQueryDatabaseMetaDataandBigQueryResultSetMetadata.BigQueryJdbcContextProxyto correctly handle unwrapping in connection proxy environments.BigQueryResultSetMetadata.isSearchableto returntruefor all column types. This fixes compliance issues where advanced types (GEOGRAPHY,JSON,INTERVAL,RANGEunderTypes.OTHER) were incorrectly reported as not searchable, even though they are fully queryable.