chore: Collect Operation and Attempt metrics for gRPC requests#12060
Open
chore: Collect Operation and Attempt metrics for gRPC requests#12060
Conversation
jinseopkim0
reviewed
Mar 10, 2026
| public static final String METHOD_PUT = "put"; | ||
| public static final String METHOD_UPDATE = "update"; | ||
| public static final String METHOD_DELETE = "delete"; | ||
| public static final String METHOD_SUBMIT = "submit"; |
Contributor
There was a problem hiding this comment.
Removing these would introduce breaking changes, right? Is this intended?
Member
Author
There was a problem hiding this comment.
These constants aren't being used. The spans still use constants in TraceUtils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.