feat(storage): add OpenTelemetryMetricsOption and env var support - #16301
Open
bajajneha27 wants to merge 1 commit into
Open
feat(storage): add OpenTelemetryMetricsOption and env var support#16301bajajneha27 wants to merge 1 commit into
bajajneha27 wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the OpenTelemetryMetricsOption to enable metrics collection with OpenTelemetry in the Google Cloud C++ SDK. It adds support for configuring this option via the GOOGLE_CLOUD_CPP_OPENTELEMETRY_METRICS environment variable, propagates it through common and authentication options, integrates it into the storage client options, and includes corresponding unit tests to verify the behavior. There are no review comments, so I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16301 +/- ##
==========================================
- Coverage 92.30% 92.30% -0.01%
==========================================
Files 2223 2223
Lines 208177 208213 +36
==========================================
+ Hits 192165 192194 +29
- Misses 16012 16019 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.