Skip to content

impl(oauth2): add RAB integration testing#16103

Open
scotthart wants to merge 2 commits into
googleapis:mainfrom
scotthart:rab_oauth2_integration
Open

impl(oauth2): add RAB integration testing#16103
scotthart wants to merge 2 commits into
googleapis:mainfrom
scotthart:rab_oauth2_integration

Conversation

@scotthart
Copy link
Copy Markdown
Member

No description provided.

@scotthart scotthart requested a review from a team as a code owner May 18, 2026 16:38
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests for Unified REST credentials, specifically covering Resource-Aware Binding (RAB) scenarios for Service Account (OAuth and JWT), Impersonated Service Account, and Compute Engine credentials. The feedback identifies a recurring safety issue across all new test cases where the code accesses the value of a StatusOr object without first verifying its status via headers.ok(), which could lead to undefined behavior upon RPC failure. The reviewer suggests updating the retry loops to include this safety check and to evaluate the condition before sleeping to avoid unnecessary delays.

Comment thread google/cloud/internal/unified_rest_credentials_integration_test.cc
Comment thread google/cloud/internal/unified_rest_credentials_integration_test.cc
Comment thread google/cloud/internal/unified_rest_credentials_integration_test.cc
Comment thread google/cloud/internal/unified_rest_credentials_integration_test.cc
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.70%. Comparing base (cf931ff) to head (dc86d0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16103   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files        2353     2353           
  Lines      218354   218437   +83     
=======================================
+ Hits       202419   202497   +78     
- Misses      15935    15940    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant