Skip to content

chore: update googleapis SHA circa 20260514 #16102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scotthart wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: update googleapis SHA circa 20260514 #16102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d165d9
chore: update googleapis SHA circa 20260514
scotthart May 18, 2026
c50710c
Update the protodeps/protolists
scotthart May 18, 2026
c2a3f8d
Regenerate libraries
scotthart May 18, 2026
f8c868f
update typos
scotthart May 18, 2026
293bba4
update MockSpannerStub
scotthart May 18, 2026
2b58cef
add bash continuation char substitution
scotthart May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ extend-exclude = [
"google/cloud/resourcemanager/v3/projects_client.h",
"google/cloud/securesourcemanager/v1/secure_source_manager_client.h",
"google/cloud/visionai/v1/warehouse_client.h",
"google/cloud/datacatalog/lineage/v1/lineage_client.h",
# The tool complains about `FIELDs` :shrug:
"/google/cloud/aiplatform/v1/featurestore_client.h",
# Files with binary blobs in base64 format. These are usually invalidated
Expand Down
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ python.toolchain(
)

bazel_dep(name = "grpc", version = "1.76.0.bcr.1")
bazel_dep(name = "googleapis", version = "0.0.0-20260422-20ac242a")
bazel_dep(name = "googleapis", version = "0.0.0-20260514-1dbb1a14")
bazel_dep(name = "googleapis-cc", version = "1.1.5")
bazel_dep(name = "googleapis-grpc-cc", version = "1.1.5")
6 changes: 3 additions & 3 deletions bazel/workspace0.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ def gl_cpp_workspace0(name = None):
http_archive,
name = "googleapis",
urls = [
"https://github.com/googleapis/googleapis/archive/20ac242a6b3a723cb10c1a0201209261addaf7d8.tar.gz",
"https://github.com/googleapis/googleapis/archive/1dbb1a14e079f78d9214f8e48bf083f32e3ddb96.tar.gz",
],
sha256 = "2e54dd6e7829afa9f382b67b3eea6730963df65381255f012ac4bd23b3654fb5",
strip_prefix = "googleapis-20ac242a6b3a723cb10c1a0201209261addaf7d8",
sha256 = "397fd8eb8a1a62dcf144216d9775816fad7a3fcff0ced1614bee529003c30d9e",
strip_prefix = "googleapis-1dbb1a14e079f78d9214f8e48bf083f32e3ddb96",
build_file = Label("//bazel:googleapis.BUILD"),
# Scaffolding for patching googleapis after download. For example:
patches = [
Expand Down
4 changes: 2 additions & 2 deletions cmake/GoogleapisConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ set(GOOGLE_CLOUD_CPP_GOOGLEAPIS_SHA256
mark_as_advanced(GOOGLE_CLOUD_CPP_GOOGLEAPIS_SHA256)

set(_GOOGLE_CLOUD_CPP_GOOGLEAPIS_COMMIT_SHA
"20ac242a6b3a723cb10c1a0201209261addaf7d8")
"1dbb1a14e079f78d9214f8e48bf083f32e3ddb96")
set(_GOOGLE_CLOUD_CPP_GOOGLEAPIS_SHA256
"2e54dd6e7829afa9f382b67b3eea6730963df65381255f012ac4bd23b3654fb5")
"397fd8eb8a1a62dcf144216d9775816fad7a3fcff0ced1614bee529003c30d9e")

set(DOXYGEN_ALIASES
"googleapis_link{2}=\"[\\1](https://github.com/googleapis/googleapis/blob/${_GOOGLE_CLOUD_CPP_GOOGLEAPIS_COMMIT_SHA}/\\2)\""
Expand Down
1 change: 1 addition & 0 deletions external/googleapis/protodeps/chronicle.deps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
@googleapis//google/api:resource_proto
@googleapis//google/longrunning:operations_proto
@googleapis//google/rpc:status_proto
@googleapis//google/type:date_proto
@googleapis//google/type:interval_proto
3 changes: 3 additions & 0 deletions external/googleapis/protodeps/container.deps
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
@googleapis//google/api:annotations_proto
@googleapis//google/api:client_proto
@googleapis//google/api:field_behavior_proto
@googleapis//google/api:field_info_proto
@googleapis//google/api:http_proto
@googleapis//google/api:launch_stage_proto
@googleapis//google/api:resource_proto
@googleapis//google/rpc:code_proto
@googleapis//google/rpc:status_proto
@googleapis//google/type:date_proto
@googleapis//google/type:timeofday_proto
2 changes: 2 additions & 0 deletions external/googleapis/protodeps/datacatalog.deps
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@googleapis//google/api:annotations_proto
@googleapis//google/api:client_proto
@googleapis//google/api:field_behavior_proto
@googleapis//google/api:field_info_proto
@googleapis//google/api:http_proto
@googleapis//google/api:launch_stage_proto
@googleapis//google/api:resource_proto
Expand All @@ -11,3 +12,4 @@
@googleapis//google/longrunning:operations_proto
@googleapis//google/rpc:status_proto
@googleapis//google/type:expr_proto
@googleapis//google/type:interval_proto
6 changes: 6 additions & 0 deletions external/googleapis/protolists/chronicle.list
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
@googleapis//google/cloud/chronicle/v1:big_query_export.proto
@googleapis//google/cloud/chronicle/v1:dashboard_chart.proto
@googleapis//google/cloud/chronicle/v1:dashboard_query.proto
@googleapis//google/cloud/chronicle/v1:data_access_control.proto
@googleapis//google/cloud/chronicle/v1:data_table.proto
@googleapis//google/cloud/chronicle/v1:entity.proto
@googleapis//google/cloud/chronicle/v1:featured_content_metadata.proto
@googleapis//google/cloud/chronicle/v1:featured_content_native_dashboard.proto
@googleapis//google/cloud/chronicle/v1:instance.proto
@googleapis//google/cloud/chronicle/v1:native_dashboard.proto
@googleapis//google/cloud/chronicle/v1:reference_list.proto
@googleapis//google/cloud/chronicle/v1:rule.proto
6 changes: 6 additions & 0 deletions generator/internal/format_method_comments.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ MethodCommentSubstitution substitutions[] = {
// process.
{R"""(---)""", R"""(-)"""},

// Some google/cloud/support/v2/* protos have example bash commands with
// continuation characters.
{"\\\n", "\n"},

// Add Doxygen-style comments
{"\n", "\n ///"},

Expand All @@ -216,6 +220,8 @@ std::string FormatMethodComments(
}
std::string doxygen_formatted_function_comments =
method_source_location.leading_comments;
absl::StrReplaceAll({{"$", "$$"}}, &doxygen_formatted_function_comments);
Copy link
Copy Markdown
Contributor

@devbww devbww May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this a member of substitutions?

Copy link
Copy Markdown
Member Author

@scotthart scotthart May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This felt more like a "good practice" to always sanitize the input to escape a known problematic character. substitutions typically contain problematic strings that we couldn't anticipate and have to add post breakage. I also wanted the sanitization to occur before we applied substitutions, which could be enforced by making it the first substitution, but that would require future updates to be mindful of.


for (auto& sub : substitutions) {
sub.uses += absl::StrReplaceAll({{sub.before, sub.after}},
&doxygen_formatted_function_comments);
Expand Down
12 changes: 6 additions & 6 deletions google/cloud/bigquerycontrol/v2/routine_client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class RoutineServiceClient {
/// [`future`]: @ref google::cloud::future
/// [`StatusOr`]: @ref google::cloud::StatusOr
/// [`Status`]: @ref google::cloud::Status
/// [google.cloud.bigquery.v2.GetRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L529}
/// [google.cloud.bigquery.v2.GetRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L534}
/// [google.cloud.bigquery.v2.Routine]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L83}
///
// clang-format on
Expand Down Expand Up @@ -139,7 +139,7 @@ class RoutineServiceClient {
/// [`future`]: @ref google::cloud::future
/// [`StatusOr`]: @ref google::cloud::StatusOr
/// [`Status`]: @ref google::cloud::Status
/// [google.cloud.bigquery.v2.InsertRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L541}
/// [google.cloud.bigquery.v2.InsertRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L546}
/// [google.cloud.bigquery.v2.Routine]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L83}
///
// clang-format on
Expand Down Expand Up @@ -172,7 +172,7 @@ class RoutineServiceClient {
/// [`StatusOr`]: @ref google::cloud::StatusOr
/// [`Status`]: @ref google::cloud::Status
/// [google.cloud.bigquery.v2.Routine]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L83}
/// [google.cloud.bigquery.v2.UpdateRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L553}
/// [google.cloud.bigquery.v2.UpdateRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L558}
///
// clang-format on
StatusOr<google::cloud::bigquery::v2::Routine> UpdateRoutine(
Expand Down Expand Up @@ -200,7 +200,7 @@ class RoutineServiceClient {
/// [`future`]: @ref google::cloud::future
/// [`StatusOr`]: @ref google::cloud::StatusOr
/// [`Status`]: @ref google::cloud::Status
/// [google.cloud.bigquery.v2.DeleteRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L568}
/// [google.cloud.bigquery.v2.DeleteRoutineRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L573}
///
// clang-format on
Status DeleteRoutine(
Expand Down Expand Up @@ -231,8 +231,8 @@ class RoutineServiceClient {
/// [`future`]: @ref google::cloud::future
/// [`StatusOr`]: @ref google::cloud::StatusOr
/// [`Status`]: @ref google::cloud::Status
/// [google.cloud.bigquery.v2.ListRoutinesRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L580}
/// [google.cloud.bigquery.v2.ListRoutinesResponse]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L602}
/// [google.cloud.bigquery.v2.ListRoutinesRequest]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L585}
/// [google.cloud.bigquery.v2.ListRoutinesResponse]: @googleapis_reference_link{google/cloud/bigquery/v2/routine.proto#L607}
///
// clang-format on
StatusOr<google::cloud::bigquery::v2::ListRoutinesResponse> ListRoutines(
Expand Down
Loading
Loading