feat(hypercomputecluster): generate library#16013
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on the foundational work of generating and integrating the C++ client library for the Google Cloud Hypercompute Cluster API. It sets up the necessary build infrastructure, documentation, and code generation configurations to support the new service, allowing developers to programmatically manage hypercompute clusters. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the generated C++ client library for the Cluster Director API (hypercomputecluster). The changes are mostly adding new files and updating configuration to include the new library. I've found a few minor issues with alphabetical ordering in documentation files and a more significant issue with the copyright year being set to a future date in the generator configuration.
| service { | ||
| service_proto_path: "google/cloud/hypercomputecluster/v1/hypercompute_cluster.proto" | ||
| product_path: "google/cloud/hypercomputecluster/v1" | ||
| initial_copyright_year: "2026" |
There was a problem hiding this comment.
The initial_copyright_year is set to "2026", which is in the future. This seems to be a typo. Please set it to the current year to ensure all generated files have the correct copyright year.
| the APIs in these libraries are stable, and are ready for production use. | ||
|
|
||
| - [Gemini Enterprise for Customer Experience API](google/cloud/ces/README.md) | ||
| - [Cluster Director API](google/cloud/hypercomputecluster/README.md) |
There was a problem hiding this comment.
To maintain alphabetical order in this list, this new entry for "Cluster Director API" should be placed before "Gemini Enterprise for Customer Experience API".
| - [Cluster Director API](google/cloud/hypercomputecluster/README.md) | ||
| [[quickstart]](google/cloud/hypercomputecluster/quickstart/README.md) | ||
| [[reference]](https://cloud.google.com/cpp/docs/reference/hypercomputecluster/latest) |
There was a problem hiding this comment.
To maintain alphabetical order in this list, this new entry for "Cluster Director API" should be placed before "GKE Recommender API".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16013 +/- ##
=======================================
Coverage 92.63% 92.64%
=======================================
Files 2333 2333
Lines 214631 214631
=======================================
+ Hits 198827 198846 +19
+ Misses 15804 15785 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
No description provided.