feat(vectorsearch): generate library#16012
Merged
scotthart merged 4 commits intogoogleapis:mainfrom Feb 27, 2026
Merged
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers the C++ client library for the Google Cloud Vector Search API. This new library empowers C++ applications to seamlessly interact with the Vector Search service, facilitating the management of collections, indexes, and data objects to leverage advanced vector search capabilities. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
jinseopkim0
approved these changes
Feb 27, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the generated C++ client library for the Vector Search API. Overall, the changes look good, and all original comments have been kept as they align with the provided rules or are not covered by them. The comments address a configuration error leading to an incorrect copyright year, suggest improvements to quickstart documentation for clarity, and identify several methods in the idempotency policies that should be marked as idempotent according to AIP guidelines, which is crucial for correct retry behavior.
| service { | ||
| service_proto_path: "google/cloud/vectorsearch/v1/data_object_service.proto" | ||
| product_path: "google/cloud/vectorsearch/v1" | ||
| initial_copyright_year: "2026" |
There was a problem hiding this comment.
The initial_copyright_year is set to 2026, which is in the future. This is likely a mistake and should be updated to the current year (e.g., 2024). This setting appears to be the root cause for the incorrect copyright year in all newly generated files in this pull request.
| 1. Run the example, changing the placeholder(s) to appropriate values: | ||
|
|
||
| ```bash | ||
| bazel run :quickstart -- [...] |
There was a problem hiding this comment.
The placeholder [...] for command-line arguments is a bit vague. It would be more helpful for users to see the expected arguments, like <project-id> <location-id>, as defined in quickstart.cc.
Suggested change
| bazel run :quickstart -- [...] | |
| bazel run :quickstart -- <project-id> <location-id> |
| 1. Run the example, changing the placeholder(s) to appropriate values: | ||
|
|
||
| ```bash | ||
| .build/quickstart [...] |
There was a problem hiding this comment.
Similar to the bazel example, it would be more helpful to show the expected arguments here, e.g., <project-id> <location-id>.
Suggested change
| .build/quickstart [...] | |
| .build/quickstart <project-id> <location-id> |
|
|
||
| Idempotency DataObjectServiceConnectionIdempotencyPolicy::CreateDataObject( | ||
| google::cloud::vectorsearch::v1::CreateDataObjectRequest const&) { | ||
| return Idempotency::kNonIdempotent; |
There was a problem hiding this comment.
CreateDataObject takes a data_object_id from the client, which makes the operation idempotent according to AIP-133. This should be kIdempotent.
return Idempotency::kIdempotent;| Idempotency | ||
| DataObjectServiceConnectionIdempotencyPolicy::BatchCreateDataObjects( | ||
| google::cloud::vectorsearch::v1::BatchCreateDataObjectsRequest const&) { | ||
| return Idempotency::kNonIdempotent; |
There was a problem hiding this comment.
BatchCreateDataObjects is a batch of CreateDataObjectRequest calls, each of which is idempotent. The batch operation should also be considered idempotent.
return Idempotency::kIdempotent;|
|
||
| Idempotency VectorSearchServiceConnectionIdempotencyPolicy::DeleteCollection( | ||
| google::cloud::vectorsearch::v1::DeleteCollectionRequest const&) { | ||
| return Idempotency::kNonIdempotent; |
There was a problem hiding this comment.
Delete operations are typically idempotent (see AIP-135). This should be kIdempotent.
return Idempotency::kIdempotent;|
|
||
| Idempotency VectorSearchServiceConnectionIdempotencyPolicy::CreateIndex( | ||
| google::cloud::vectorsearch::v1::CreateIndexRequest const&) { | ||
| return Idempotency::kNonIdempotent; |
There was a problem hiding this comment.
CreateIndex takes an index_id from the client, which makes the operation idempotent according to AIP-133. This should be kIdempotent.
return Idempotency::kIdempotent;|
|
||
| Idempotency VectorSearchServiceConnectionIdempotencyPolicy::DeleteIndex( | ||
| google::cloud::vectorsearch::v1::DeleteIndexRequest const&) { | ||
| return Idempotency::kNonIdempotent; |
There was a problem hiding this comment.
Delete operations are typically idempotent (see AIP-135). This should be kIdempotent.
return Idempotency::kIdempotent;|
|
||
| Idempotency VectorSearchServiceConnectionIdempotencyPolicy::DeleteOperation( | ||
| google::longrunning::DeleteOperationRequest const&) { | ||
| return Idempotency::kNonIdempotent; |
There was a problem hiding this comment.
DeleteOperation should be idempotent as per AIP-154.
return Idempotency::kIdempotent;|
|
||
| Idempotency VectorSearchServiceConnectionIdempotencyPolicy::CancelOperation( | ||
| google::longrunning::CancelOperationRequest const&) { | ||
| return Idempotency::kNonIdempotent; |
There was a problem hiding this comment.
CancelOperation should be idempotent as per AIP-155.
return Idempotency::kIdempotent;
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16012 +/- ##
=======================================
Coverage 92.63% 92.64%
=======================================
Files 2333 2333
Lines 214631 214631
=======================================
+ Hits 198830 198846 +16
+ Misses 15801 15785 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.