This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: adds trust boundary lookup support for SA and impersonated credentials#1671
Closed
aeitzman wants to merge 1 commit intogoogleapis:mainfrom
Closed
feat: adds trust boundary lookup support for SA and impersonated credentials#1671aeitzman wants to merge 1 commit intogoogleapis:mainfrom
aeitzman wants to merge 1 commit intogoogleapis:mainfrom
Conversation
…rsonated credentials
aeitzman
added
the
do not merge
nbayati
reviewed
Feb 28, 2025
| from google.auth._refresh_worker import RefreshThreadManager | ||
|
|
||
| DEFAULT_UNIVERSE_DOMAIN = "googleapis.com" | ||
| NO_OP_TRUST_BOUNDARY_LOCATIONS: "typing.Tuple[str]" = () |
Contributor
There was a problem hiding this comment.
I know in the design doc we had an empty list for locations field in the response but it turns out the lookup endpoint only returns "encodedLocations": "0x0" if an account is not allow-listed, or trust boundary has not been setup. I got this response from the endpoint when testing, and confirmed it with Annan.
{
"encodedLocations": "0x0"
}
So we need to update both the _parse_trust_boundary and _has_no_op_trust_boundary methods.
Contributor
|
Switching to draft as there are merge conflicts |
Contributor
|
Closing:
If this is a change that is deemed critical, we can re-open on the new location once this repo has been migrated to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.