Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Jan 28, 2026

See b/479228571 for more information.

Attempts to resolve any deserialization issue when trying to create a new HttpTransportFactory. Validates so that a HttpTransportFactory implementation can be created to prevent arbitrary loading of classes (e.g. gadget classes that can execute commands).

Mimics the existing loading behavior in the constructor:

  • Checks the ServiceLoader for any implementation
  • Attempts to use the default
  • Loads any custom implementation and tries to ensure that it's valid and loading doesn't run any static code.

@lqiu96 lqiu96 requested a review from zhumin8 January 28, 2026 20:00
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 28, 2026
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant