fix(deps): add multi_json dependency to 8 legacy REST gems - #27547
Merged
Conversation
torreypayne
force-pushed
the
fix/modernize-legacy-core-constraints
branch
from
August 3, 2026 16:56
bda7bf6 to
2f8c801
Compare
…g core ~> 0.1) In 8 older, unregenerated REST client gems (`cloudshell_v1alpha1`, `appengine_v1beta4`, `appengine_v1beta5`, `youtube_partner_v1`, `youtube_analytics_v1`, `genomics_v1`, `genomics_v1alpha2`, `analyticsdata_v1alpha`), the runtime constraint for google-apis-core is `~> 0.1` (`>= 0.1.0, < 1.0.0`). To avoid a major version bump to 1.X during lockfile seeding while fixing the dormant CI test failure (`Gem::LoadError: multi_json is not part of the bundle`), this PR preserves the original `google-apis-core ~> 0.1` constraint and adds `gem.add_runtime_dependency "multi_json", "~> 1.0"` directly to the 8 `.gemspec` files.
torreypayne
force-pushed
the
fix/modernize-legacy-core-constraints
branch
from
August 3, 2026 17:08
2f8c801 to
e1e13d3
Compare
torreypayne
marked this pull request as ready for review
August 3, 2026 17:14
aandreassa
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In 8 older, unregenerated REST client libraries (
cloudshell_v1alpha1,appengine_v1beta4,appengine_v1beta5,youtube_partner_v1,youtube_analytics_v1,genomics_v1,genomics_v1alpha2,analyticsdata_v1alpha), the runtime constraint forgoogle-apis-coreis set to~> 0.1(>= 0.1.0, < 1.0.0).This PR fixes a dormant CI load error in these 8 gems by explicitly adding
gem.add_runtime_dependency "multi_json", "~> 1.0"to their.gemspecfiles while preserving the originalgoogle-apis-core ~> 0.1constraint (no 1.x major version bump).See workflow run for an example of the CI error.
💥 Reproducible Error Sample (Without This Fix)
When running tests (
bundle install && toys _nested specorrequire "google/apis/cloudshell_v1alpha1") in any of these 8 legacy directories withoutmulti_jsonin the bundle, RSpec/Bundler crashes with the following error:🔍 Why This Error Occurs
google-apis-core-0.18.0is loaded:The legacy library specifies
gem.add_runtime_dependency "google-apis-core", "~> 0.1", which restrictsgoogle-apis-coreto the0.xmajor version series (resolving0.18.0).representable-3.2.0is loaded:google-apis-core (0.18.0)requiresrepresentable (~> 3.0), which resolves the latest 3.x version (representable 3.2.0).multi_json is not part of the bundle):representable 3.2.0callsrequire "multi_json". However, becausegoogle-apis-core 0.18.0predates PR #26612 (which added an explicit runtime dependency onmulti_jsontogoogle-apis-core 1.2.1+), neithergoogle-apis-core (0.18.0)norrepresentable (3.2.0)declares a gem dependency onmulti_json.When Bundler loads the gem (
require "bundler/setup"), it blocks unlisted gems, raisingGem::LoadError: multi_json is not part of the bundle.🛠️ Why This Fix Is Minimal & Safe
google-apis-coreto1.x(>= 0.15.0, < 2.a), we preserve~> 0.1so downstream consumers experience no major version bump.gem.add_runtime_dependency "multi_json", "~> 1.0"directly to the 8 legacy.gemspecfiles, ensuringmulti_jsonis present in the bundle whenrepresentable 3.2.0loads.