fix(ci): pull latest upstream changes after syncing fork in update-apis workflow - #3963
Open
westarle wants to merge 1 commit into
Open
fix(ci): pull latest upstream changes after syncing fork in update-apis workflow#3963westarle wants to merge 1 commit into
westarle wants to merge 1 commit into
Conversation
…is workflow gh repo fork --clone clones the fork onto disk before gh repo sync --force runs. Since gh repo sync only updates the remote fork on GitHub servers and does not touch the local working directory, add a 'git pull' step so the local checkout updates to the latest synced upstream main immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
.github/workflows/update-apis.yaml, step 1 (gh repo fork --clone) clonesyoshi-code-bot's fork onto the Actions runner disk before step 2 (gh repo sync --force) syncs it.Since
gh repo syncis an API call that only updates the remote repository on GitHub servers and does not touch the local working directory, the clone on disk remained 1 run behindupstream/main(which caused run 30851788978 to run the unpatchedsynth.tsscript prior to PR #3962).Adding a
git pullstep immediately after syncing ensures the local clone updates to the latest synced upstream commit before executing the generator.