Conversation
sachinpro
force-pushed
the
fix_timestamp_escape_clause
branch
from
September 12, 2026 01:40
e5e9fde to
9277c03
Compare
sachinpro
force-pushed
the
fix_timestamp_escape_clause
branch
from
September 12, 2026 01:47
9277c03 to
fd6f2f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for ODBC timestamp/date/time and other escape sequences (e.g.
{ts '...'},{d '...'},{t '...'},{escape '...'},{oj ...},{fn ...}) in queries.Changes
TranslateOdbcEscapeSequencesingoogle/cloud/odbc/bq_driver/internal/utils.ccto parse and translate ODBC escape clauses into BigQuery SQL syntax while preserving comments, quoted string literals, and BigQuery struct literals.StatementHandle::PrepareQueryto invokeTranslateOdbcEscapeSequenceswhenSQL_ATTR_NOSCANis not set toSQL_NOSCAN_ON.google/cloud/odbc/bq_driver/internal/utils_test.ccfor datetime literals, escape/outer joins, and preserving strings/comments/structs.StatementTest.OdbcEscapeTimestampLiteralingoogle/cloud/odbc/integration_tests/odbc_driver_tests/statement_test.ccverifying bothSQLExecDirectandSQLPrepare/SQLExecuteworkflows.