chore: Remove information_schema reference - #1656
Open
shadabraza-droid wants to merge 1 commit into
Open
shadabraza-droid wants to merge 1 commit into
shadabraza-droid wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
shadabraza-droid
marked this pull request as draft
September 9, 2026 21:39
shadabraza-droid
force-pushed
the
remove_information_schema
branch
from
September 9, 2026 22:04
1aaeb42 to
bd879b8
Compare
shadabraza-droid
changed the title
shadabraza-droid
force-pushed
the
remove_information_schema
branch
2 times, most recently
from
September 10, 2026 13:46
960a1d4 to
e933d29
Compare
shadabraza-droid
marked this pull request as ready for review
September 10, 2026 19:35
shadabraza-droid
force-pushed
the
remove_information_schema
branch
2 times, most recently
from
September 14, 2026 21:05
79e9757 to
02deebd
Compare
shadabraza-droid
force-pushed
the
remove_information_schema
branch
from
September 15, 2026 05:21
02deebd to
2f3541a
Compare
| @@ -29,20 +29,6 @@ std::string const kNamedCatalogParam = "catalog_name"; | |||
Contributor
There was a problem hiding this comment.
remove these as well , not being used anywhere infact this whole namespace can be removed
…d add integration tests
shadabraza-droid
force-pushed
the
remove_information_schema
branch
from
September 15, 2026 07:01
2f3541a to
d2d09e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the INFORMATION_SCHEMA reference from all the files.
For file google/cloud/odbc/bq_driver/internal/odbc_sql_foreign_keys.cc
Old:
SQLForeignKeys()queriedINFORMATION_SCHEMAusingFetchBQData()to get foreign-key rows.New: It uses
tables.listviaGetFilteredTables()andFetchBQTableData()to readForeignKeymetadata directly, then converts it to ODBC rows withAppendForeignKeyRows().This removes the
INFORMATION_SCHEMAdependency while preserving the existingSQLForeignKeys()behavior.