fix: Update driver version in windows CI - #1652
Open
KanchanShu wants to merge 1 commit into
Open
KanchanShu wants to merge 1 commit into
KanchanShu wants to merge 1 commit into
Conversation
KanchanShu
force-pushed
the
update_package_version
branch
from
September 7, 2026 11:05
80f1ed8 to
fab3d00
Compare
KanchanShu
marked this pull request as ready for review
September 16, 2026 06:40
Collaborator
|
We want to pass the driver version through windows-cmake.yml and it has to be "99.99.99" so that it will override any local version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI builds had
ODBC_GOOGLE_DRIVER_VERSIONhardcoded to99.99.99, causing the MSI to always be created asODBCDriverforBigQuery_windows_x64_99.99.99.msi. Additionally,-DPROJECT_VERSIONwas never passed to CMake, so the DLL's internalkDriverVerwas always1.0.0— inconsistent with the MSI filename.This PR removes the hardcoding and makes
CMakeLists.txtthe single source of truth. The version is now extracted dynamically and passed through the entire pipeline, so the DLL and MSI filename always match the actual project version — consistent with how the release workflow already handles it.Files changed:
.github/workflows/windows-cmake.ymlci/gha/builds/windows-cmake-integration.sh