improve(bq_driver): SQLForeign Key perf imporvement - #1614
Open
shivamd-gpartner wants to merge 2 commits into
Open
improve(bq_driver): SQLForeign Key perf imporvement#1614shivamd-gpartner wants to merge 2 commits into
shivamd-gpartner wants to merge 2 commits into
Conversation
shivamd-gpartner
temporarily deployed
to
internal
July 28, 2026 06:21 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
shivamd-gpartner
force-pushed
the
SQLForeign_key_perf
branch
from
July 28, 2026 07:49
66927b2 to
a007067
Compare
shivamd-gpartner
force-pushed
the
SQLForeign_key_perf
branch
from
July 28, 2026 08:11
a007067 to
2d86589
Compare
NeerajDwivedii
force-pushed
the
SQLForeign_key_perf
branch
from
July 28, 2026 08:28
b7b67ed to
2d86589
Compare
shivamd-gpartner
marked this pull request as ready for review
July 28, 2026 09:06
sachinpro
reviewed
Jul 28, 2026
| # Patch table_constraints.cc: the BigQuery REST API returns the foreign key | ||
| # constraint name in the "name" field, but the minimal client only reads | ||
| # "keyName", so key_name always parses as empty. Read "name" first. | ||
| set(fk_name_search "void from_json(nlohmann::json const& j, ForeignKey& f) { |
Collaborator
There was a problem hiding this comment.
Lets handle it in the implementation if possible. This patch file is only for resolving compilation issues.
Collaborator
Author
There was a problem hiding this comment.
removed the dependency
shivamd-gpartner
temporarily deployed
to
internal
July 30, 2026 07:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve(bq_driver): Optimize SQLForeignKeys via tables.get REST API
SQLForeignKeys always ran an INFORMATION_SCHEMA query job.
When the FK table is given as an exact name (ODBC treats it as an
identifier, not a pattern), read
tableConstraintsfrom thetables.getRESTAPI instead and build the result set locally — same approach as the existing
SQLPrimaryKeys
/SQLColumns optimizations. Covers FK-only and PK+FK cases;names with
%and the PK-only case keep the unchanged query path.benchmark_summary_table.txt