Add method to extract all errors of a partial failure status at once#626
Open
markusheiden wants to merge 1 commit intogoogleads:mainfrom
Open
Add method to extract all errors of a partial failure status at once#626markusheiden wants to merge 1 commit intogoogleads:mainfrom
markusheiden wants to merge 1 commit intogoogleads:mainfrom
Conversation
This is useful because getting all errors via their operation index is inefficient. In #getGoogleAdsErrors(long, GoogleAdsFailureT) the error paths for all failures are build just to pick those for the requested operation index. That leads creation of many ErrorPath objects for all not requested operation indexes which. Those are immediately discarded what leads to avoidable GC pressure. This can already be achieved with the current API, but I think it belongs into the error util. The code (Java 11) I currently use as supplement: status.getDetailsList().stream() .map(errorUtils::getGoogleAdsFailure) .map(errorUtils::getGoogleAdsErrors) .flatMap(List::stream) .collect(toSet());
Author
|
When implementing this PR I wondered why the errors in This applies to other methods too, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful because getting all errors via their operation index is inefficient. In #getGoogleAdsErrors(long, GoogleAdsFailureT) the error paths for all failures are build just to pick those for the requested operation index. That leads creation of many ErrorPath objects for all not requested operation indexes which. Those are immediately discarded what leads to avoidable GC pressure.
This can already be achieved with the current API, but I think it belongs into the error util. The code (Java 11) I currently use as supplement:
status.getDetailsList().stream()
.map(errorUtils::getGoogleAdsFailure)
.map(errorUtils::getGoogleAdsErrors)
.flatMap(List::stream)
.collect(toSet());