Skip to content

chore(formatter): Update formatter to handle plus signs in emails with Google domains #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindsey-volta merged 3 commits into from
Jun 2, 2026
Merged

chore(formatter): Update formatter to handle plus signs in emails with Google domains #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0248e69
chore(format): Update formatter to handle Google domain email addresses
lindsey-volta Jun 1, 2026
fe42d36
Update email addresses
lindsey-volta Jun 1, 2026
06025a3
Update version of util library
lindsey-volta Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data-manager-util/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins {

group = 'com.google.api-ads'
description = 'Utilities for working with the Data Manager API'
version = '0.2.0'
version = '0.3.0'

sourceCompatibility = 1.8
targetCompatibility = 1.8
Expand Down
6 changes: 6 additions & 0 deletions data-manager-util/src/main/java/com/google/ads/datamanager/util/UserDataFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,12 @@ public String formatEmailAddress(String emailAddress) {
// "Create variations of your email address" at:
// https://support.google.com/a/users/answer/9282734

// Removes plus sign (+) and all characters that follow it.
int plusIndex = username.indexOf('+');
if (plusIndex != -1) {
username = username.substring(0, plusIndex);
}

// Removes all periods (.).
username = PERIOD_PATTERN.matcher(username).replaceAll("");
}
Expand Down
12 changes: 12 additions & 0 deletions data-manager-util/src/test/java/com/google/ads/datamanager/util/UserDataFormatterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ public void testFormatEmailAddress_validInputs() {
"Case should be normalized in domain",
"quinny@example.com",
formatter.formatEmailAddress("QuinnY@EXAMPLE.com"));
assertEquals(
"Plus sign and everything after should not be stripped from non google emails",
"user.name+nyc@example.com",
formatter.formatEmailAddress("user.name+NYC@Example.com"));
}

@Test
Expand Down Expand Up @@ -69,6 +73,14 @@ public void testFormatEmailAddress_gmailVariations() {
assertEquals(
"jeffersonloveshiking@googlemail.com",
formatter.formatEmailAddress("j.e.f..ferson.Loves.hiking@googlemail.com"));
assertEquals(
"Plus sign and everything after should be stripped from gmail.com address",
"cloudysanfrancisco@gmail.com",
formatter.formatEmailAddress("Cloudy.SanFrancisco+shopping@gmail.com"));
assertEquals(
"Plus sign and everything after should be stripped from googlemail.com address",
"cloudysanfrancisco@googlemail.com",
formatter.formatEmailAddress("Cloudy.SanFrancisco+shopping@googlemail.com"));
}

@Test
Expand Down