Qualify KnownLayout metadata extraction - #3625
Conversation
Generated KnownLayout implementations called pointer_to_metadata through a concrete trailing type. A same-named inherent method could therefore capture the call and supply metadata that violates the unsafe trait's layout contract. Emit a fully trait-qualified call for both the derived type and its generated MaybeUninit form. Extend the output hygiene check to reject unqualified associated-item syntax, and add compile-time and semantic regressions for an inherent-method collision. Closes #3621 *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* gherrit-pr-id: Gkpenpjjuex55evmm52puxsa34xtjgc7t
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3625 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Generated KnownLayout implementations called pointer_to_metadata through a
concrete trailing type. A same-named inherent method could therefore capture
the call and supply metadata that violates the unsafe trait's layout contract.
Emit a fully trait-qualified call for both the derived type and its generated
MaybeUninit form. Extend the output hygiene check to reject unqualified
associated-item syntax, and add compile-time and semantic regressions for an
inherent-method collision.
Closes #3621
Authored by an AI agent acting on Josh Liebow-Feeser's behalf.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gkpenpjjuex55evmm52puxsa34xtjgc7t && git checkout -b pr-Gkpenpjjuex55evmm52puxsa34xtjgc7t FETCH_HEADCheckout
git fetch origin refs/heads/Gkpenpjjuex55evmm52puxsa34xtjgc7t && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gkpenpjjuex55evmm52puxsa34xtjgc7t && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.