Seal derive padding witnesses - #3623
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3623 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5eba0c8 to
d6c5c71
Compare
The IntoBytes derive relies on const-generic padding witnesses, but downstream safe code could implement the public witness traits for nonzero padding values and make the derive emit an unsound impl. Require private predicates over the complete type-and-const tuple, with implementations only for zero static padding and false dynamic padding. Add compile-fail tests showing that direct false witness implementations no longer satisfy the authentic Zerocopy traits. Closes #3614 *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* gherrit-pr-id: Gowln6kqlymxhdw2dwz5uf46fnryyxouu
d6c5c71 to
1b1460b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The IntoBytes derive relies on const-generic padding witnesses, but
downstream safe code could implement the public witness traits for nonzero
padding values and make the derive emit an unsound impl.
Require private predicates over the complete type-and-const tuple, with
implementations only for zero static padding and false dynamic padding. Add
compile-fail tests showing that direct false witness implementations no longer
satisfy the authentic Zerocopy traits.
Closes #3614
Authored by an AI agent acting on Josh Liebow-Feeser's behalf.
Latest Update: v3 — Compare vs v2
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gowln6kqlymxhdw2dwz5uf46fnryyxouu && git checkout -b pr-Gowln6kqlymxhdw2dwz5uf46fnryyxouu FETCH_HEADCheckout
git fetch origin refs/heads/Gowln6kqlymxhdw2dwz5uf46fnryyxouu && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gowln6kqlymxhdw2dwz5uf46fnryyxouu && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.