Make pointer Read witnesses unsafe - #3622
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3622 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
948b43f to
a8037b4
Compare
a8037b4 to
2679707
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The public Read witness is trusted by pointer conversions to prove that unsynchronized reads are permitted, but downstream code could previously implement it without taking responsibility for that invariant. Make Read an unsafe trait, document its implementor obligation, and justify the two built-in implementations. Closes #3613 *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* gherrit-pr-id: Gugofjuaaownqfvbulg6lh72eul7phdgb
2679707 to
56e6bda
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The public Read witness is trusted by pointer conversions to prove that
unsynchronized reads are permitted, but downstream code could previously
implement it without taking responsibility for that invariant.
Make Read an unsafe trait, document its implementor obligation, and justify
the two built-in implementations.
Closes #3613
Authored by an AI agent acting on Josh Liebow-Feeser's behalf.
Latest Update: v4 — Compare vs v3
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gugofjuaaownqfvbulg6lh72eul7phdgb && git checkout -b pr-Gugofjuaaownqfvbulg6lh72eul7phdgb FETCH_HEADCheckout
git fetch origin refs/heads/Gugofjuaaownqfvbulg6lh72eul7phdgb && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gugofjuaaownqfvbulg6lh72eul7phdgb && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.