[codegen] Use descriptive benchmark target fn name.

[jswrenn]

---

• 　  [codegen] Test and document codegen under different layouts #3085
• 　  [codegen] Make codegen tests even more stressful. #3083
• 👉 [codegen] Use descriptive benchmark target fn name. #3082
• 　  [codegen] Track unanalyzed assembly and include it in docs. #3081

Latest Update: v5 — Compare vs v4

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	v4	v3	v2	v1	Base
v5	vs v4	vs v3	vs v2	vs v1	vs Base
v4		vs v3	vs v2	vs v1	vs Base
v3			vs v2	vs v1	vs Base
v2				vs v1	vs Base
v1					vs Base

⬇️ Download this PR

Branch

git fetch origin refs/heads/Gff7f5c476000b38dbce1a040586076c9ff44a8d4 && git checkout -b pr-Gff7f5c476000b38dbce1a040586076c9ff44a8d4 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gff7f5c476000b38dbce1a040586076c9ff44a8d4 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gff7f5c476000b38dbce1a040586076c9ff44a8d4 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gff7f5c476000b38dbce1a040586076c9ff44a8d4

Stacked PRs enabled by GHerrit.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the naming convention for benchmark functions and their associated test infrastructure. The primary goal is to improve the clarity and readability of benchmark tests by assigning more descriptive names to the functions being benchmarked. This change is consistently applied across the Rust source files, their generated assembly outputs, and the test runner, ensuring that the benchmark targets are easily identifiable and their purpose is immediately clear.

Highlights

• Benchmark Function Renaming: Renamed all codegen_test functions in benchmark files (e.g., ref_from_bytes.rs, transmute_ref.rs) to more descriptive names following the pattern bench_<operation_name> (e.g., bench_ref_from_bytes, bench_transmute_ref).
• Assembly Output Updates: Updated the corresponding .x86-64 assembly output files to reflect the new benchmark function names, ensuring consistency between Rust source and generated assembly.
• Dynamic Benchmark Test Invocation: Modified tests/codegen.rs to dynamically construct the benchmark function name for cargo-asm commands using format!("bench_{bench_name}"), removing the hardcoded codegen_test string.
• Improved Error Reporting: Enhanced error output in tests/codegen.rs for failed cargo-asm commands, now including both stdout and stderr for better debugging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• benches/ref_from_bytes.rs
  • Renamed codegen_test function to bench_ref_from_bytes.
• benches/ref_from_bytes.x86-64
  • Updated the function name from codegen_test to bench_ref_from_bytes.
• benches/ref_from_bytes_with_elems.rs
  • Renamed codegen_test function to bench_ref_from_bytes_with_elems.
• benches/ref_from_bytes_with_elems.x86-64
  • Updated the function name from codegen_test to bench_ref_from_bytes_with_elems.
• benches/ref_from_prefix.rs
  • Renamed codegen_test function to bench_ref_from_prefix.
• benches/ref_from_prefix.x86-64
  • Updated the function name from codegen_test to bench_ref_from_prefix.
• benches/ref_from_prefix_with_elems.rs
  • Renamed codegen_test function to bench_ref_from_prefix_with_elems.
• benches/ref_from_prefix_with_elems.x86-64
  • Updated the function name from codegen_test to bench_ref_from_prefix_with_elems.
• benches/ref_from_suffix.rs
  • Renamed codegen_test function to bench_ref_from_suffix.
• benches/ref_from_suffix.x86-64
  • Updated the function name from codegen_test to bench_ref_from_suffix.
• benches/ref_from_suffix_with_elems.rs
  • Renamed codegen_test function to bench_ref_from_suffix_with_elems.
• benches/ref_from_suffix_with_elems.x86-64
  • Updated the function name from codegen_test to bench_ref_from_suffix_with_elems.
• benches/transmute_ref.rs
  • Renamed codegen_test function to bench_transmute_ref.
• benches/transmute_ref.x86-64
  • Updated the function name from codegen_test to bench_transmute_ref.
• benches/try_ref_from_bytes.rs
  • Renamed codegen_test function to bench_try_ref_from_bytes.
• benches/try_ref_from_bytes.x86-64
  • Updated the function name from codegen_test to bench_try_ref_from_bytes.
• benches/try_ref_from_bytes_with_elems.rs
  • Renamed codegen_test function to bench_try_ref_from_bytes_with_elems.
• benches/try_ref_from_bytes_with_elems.x86-64
  • Updated the function name from codegen_test to bench_try_ref_from_bytes_with_elems.
• benches/try_ref_from_prefix.rs
  • Renamed codegen_test function to bench_try_ref_from_prefix.
• benches/try_ref_from_prefix.x86-64
  • Updated the function name from codegen_test to bench_try_ref_from_prefix.
• benches/try_ref_from_prefix_with_elems.rs
  • Renamed codegen_test function to bench_try_ref_from_prefix_with_elems and adjusted function signature formatting.
• benches/try_ref_from_prefix_with_elems.x86-64
  • Updated the function name from codegen_test to bench_try_ref_from_prefix_with_elems.
• benches/try_ref_from_suffix.rs
  • Renamed codegen_test function to bench_try_ref_from_suffix.
• benches/try_ref_from_suffix.x86-64
  • Updated the function name from codegen_test to bench_try_ref_from_suffix.
• benches/try_ref_from_suffix_with_elems.rs
  • Renamed codegen_test function to bench_try_ref_from_suffix_with_elems and adjusted function signature formatting.
• benches/try_ref_from_suffix_with_elems.x86-64
  • Updated the function name from codegen_test to bench_try_ref_from_suffix_with_elems.
• benches/try_transmute_ref.rs
  • Renamed codegen_test function to bench_try_transmute_ref.
• benches/try_transmute_ref.x86-64
  • Updated the function name from codegen_test to bench_try_transmute_ref.
• tests/codegen.rs
  • Updated the cargo-asm command to use a dynamically formatted benchmark function name.
  • Improved error reporting for failed cargo-asm commands by printing both stdout and stderr.

Activity

• The pull request description was automatically generated by GHerrit.
• This PR is part of a stacked series, with a parent PR Ged67b8f5ad7d38d9f2eb40adebea8894a1a6a008.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (bdb1480) to head (bf3201c).

Additional details and impacted files

@@                            Coverage Diff                             @@
##           Ged67b8f5ad7d38d9f2eb40adebea8894a1a6a008    #3082   +/-   ##
==========================================================================
  Coverage                                      91.87%   91.87%           
==========================================================================
  Files                                             20       20           
  Lines                                           6057     6057           
==========================================================================
  Hits                                            5565     5565           
  Misses                                           492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request refactors the codegen benchmark tests to use descriptive function names instead of the generic codegen_test. This is achieved by updating the test runner to construct the function name from the benchmark file name. The changes are straightforward and improve the maintainability of the benchmarks. I have one suggestion to remove a debugging print statement from the test runner.