Remove python 2 init symbols to get compilation to work on 3.12.4#239
Open
pritamdodeja wants to merge 1 commit intogoogle:masterfrom
Open
Remove python 2 init symbols to get compilation to work on 3.12.4#239pritamdodeja wants to merge 1 commit intogoogle:masterfrom
pritamdodeja wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Stricter llvm linker was not allowing compilation to succeed.
3f56c2c to
163eb6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stricter llvm linker was not allowing ml-metadata compilation to succeed.
Background: I'm trying to get TFX running on a more modern python, specifically 3.12.4, and this is a fix that unblocks the building of ml-metadata in my environment. Open to any suggestions about better ways to do this. The underlying error that this resolves in my environment is below: