add loads for cc rules to BUILD files#1260
Merged
johnbartholomew merged 3 commits intogoogle:masterfrom Jan 21, 2026
Merged
Conversation
Contributor
|
@johnbartholomew this PR is needed to use jsonnet/go-jsonnet with Bazel 9. Do you think we could get it merged? |
Collaborator
|
Sorry for the delay in reviewing this. Two notes:
|
This was referenced Jan 21, 2026
Merged
Collaborator
|
Could you also sync with master (rebase ideally, but merge if you prefer)? I have updated the CI workflow to check multiple Bazel versions for the example of using the library with bazel, and it would be good to confirm that v7, v8, and v9 all work with this PR (currently on master v7 and v8 work but v9 does not, as noted in mortenmj's comment) |
Contributor
Author
|
Thank you for the review. I have added |
builtin rules are removed in newer versions of Bazel
johnbartholomew
force-pushed
the
rules_cc
branch
from
7c604c5 to
a37ea3e
Compare
Collaborator
|
Rebased for linear history, and merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builtin rules are removed in newer versions of Bazel