Emit inline Swift wrappers for C functions when --no-wrapper-methods is set. - #2829
Open
copybara-service[bot] wants to merge 1 commit into
Open
Emit inline Swift wrappers for C functions when --no-wrapper-methods is set.#2829copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…is set. When --no-wrapper-methods is enabled in a `@SwiftName` context, C functions previously received an `NS_SWIFT_NAME` attribute directly on their `FOUNDATION_EXPORT` declaration. This caused Clang to emit 'obsoleted in Swift 3' availability warnings when Swift clients attempted to invoke the C functions directly. This change keeps `FOUNDATION_EXPORT` C function declarations unannotated and generates an inline wrapper function (`NS_INLINE ..._swiftName(...) NS_SWIFT_NAME(...)`) forwarding calls to the C function. This allows Swift clients to call either the C function directly or use the Swift name wrapper. PiperOrigin-RevId: 960494238
copybara-service
Bot
force-pushed
the
test_960494238
branch
from
August 6, 2026 22:01
e58e4e4 to
f5220bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit inline Swift wrappers for C functions when --no-wrapper-methods is set.
When --no-wrapper-methods is enabled in a
@SwiftNamecontext, C functions previously received anNS_SWIFT_NAMEattribute directly on theirFOUNDATION_EXPORTdeclaration. This caused Clang to emit 'obsoleted in Swift 3' availability warnings when Swift clients attempted to invoke the C functions directly.This change keeps
FOUNDATION_EXPORTC function declarations unannotated and generates an inline wrapper function (NS_INLINE ..._swiftName(...) NS_SWIFT_NAME(...)) forwarding calls to the C function. This allows Swift clients to call either the C function directly or use the Swift name wrapper.