fix: donate EROFS submount FDs in goferless mode#13663
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix: donate EROFS submount FDs in goferless mode#13663copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
ecca239 to
ba1bfc8
Compare
When an EROFS rootfs runs without a gofer process, runsc still has to provide image FDs for EROFS config mounts. The goferless path only opened the rootfs image, so boot could run out of gofer FDs while preparing submounts. This patch donates EROFS submount image FDs in config mount order and adds a test to cover such case. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13597 from tianyuzhou95:albert/erofs-mount-fix 87177a7 PiperOrigin-RevId: 945300154
ba1bfc8 to
cd802c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: donate EROFS submount FDs in goferless mode
When an EROFS rootfs runs without a gofer process, runsc still has to provide image FDs for EROFS config mounts. The goferless path only opened the rootfs image, so boot could run out of gofer FDs while preparing submounts.
This patch donates EROFS submount image FDs in config mount order and adds a test to cover such case.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#13597 from tianyuzhou95:albert/erofs-mount-fix 87177a7