Skip to content

Include logVarargs in google-java-format formatting special case #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
May 19, 2026
+9 −1
Merged

Include logVarargs in google-java-format formatting special case #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/com/google/googlejavaformat/java/JavaInputAstVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1689,7 +1689,8 @@ public Void visitMethodInvocation(MethodInvocationTree node, Void unused) {
* }</pre>
*/
private boolean handleLogStatement(MethodInvocationTree node) {
if (!getMethodName(node).contentEquals("log")) {
Name methodName = getMethodName(node);
if (!methodName.contentEquals("log") && !methodName.contentEquals("logVarargs")) {
return false;
}
Deque<ExpressionTree> parts = new ArrayDeque<>();
Expand Down
5 changes: 5 additions & 0 deletions core/src/test/resources/com/google/googlejavaformat/java/testdata/B25787055.input
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,10 @@ class B25787055 {
"Scratch Session Cleaner exiting. Number of deleted sessions: %d, names: %s",
deletedPersistentNames.size(),
deletedPersistentNames);
logger
.atInfo()
.logVarargs(
"Scratch Session Cleaner exiting. Number of deleted sessions: %d, names: %s",
arguments);
}
}
2 changes: 2 additions & 0 deletions core/src/test/resources/com/google/googlejavaformat/java/testdata/B25787055.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,7 @@ class B25787055 {
.log(
"Scratch Session Cleaner exiting. Number of deleted sessions: %d, names: %s",
deletedPersistentNames.size(), deletedPersistentNames);
logger.atInfo().logVarargs(
"Scratch Session Cleaner exiting. Number of deleted sessions: %d, names: %s", arguments);
}
}
Loading