feat: Add ImageGen to HostedRunner and UpdateHostedRunnerRequest - #4549
Open
jdymitarai wants to merge 1 commit into
Open
feat: Add ImageGen to HostedRunner and UpdateHostedRunnerRequest#4549jdymitarai wants to merge 1 commit into
jdymitarai wants to merge 1 commit into
Conversation
Add ImageGen (*bool) to HostedRunner and UpdateHostedRunnerRequest to allow reading back and updating the image generation setting for GitHub-hosted runners. Fixes google#4532
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4549 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 197 197
Lines 18252 18252
=======================================
Hits 17991 17991
Misses 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Sep 13, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @jdymitarai!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4532
Supersedes #4544 (blocked on unsigned CLA from bot account).
Cause
The GitHub-hosted runner API supports
image_genon create, read, and update. Currently,go-githubonly includesImageGeninCreateHostedRunnerRequest, making it impossible to read back or update the image generation configuration of runner pools.Solution
ImageGen *booljson:"image_gen,omitempty"`` toHostedRunnerand `UpdateHostedRunnerRequest`.github-accessors.goandgithub-accessors_test.goviago generate ./....TestHostedRunner_MarshalandTestUpdateHostedRunnerRequest_Marshalverifying JSON round-trip marshaling.AI assistance: Drafted marshal tests and verified accessor generation against the OpenAPI spec.