fix: Escape package names in UsersService methods

[pucedoteth]

UsersService.GetPackage escapes packageName, but the other seven package methods interpolate it raw, so a name containing a slash produces a malformed path. Container and scoped npm package names routinely contain one.

OrganizationsService already escapes it in all seven equivalent methods and documents it, so this just brings the user methods in line: 12 call sites escaped, plus the same doc note.

The existing tests missed this because only the GetPackage test uses a slashed name (hello/hello_docker); the rest use hello_docker. The new test uses a slashed name against every affected method — all ten sub-cases fail without the change and pass with it.

AI assistance: Claude Code found the inconsistency, made the edits, and drafted the test and this description. I reviewed the diff and ran script/fmt.sh, script/generate.sh (no drift), script/lint.sh and script/test.sh.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (2433615) to head (5d36ebb).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4546      +/-   ##
==========================================
+ Coverage   98.54%   98.57%   +0.02%     
==========================================
  Files         196      197       +1     
  Lines       17938    18252     +314     
==========================================
+ Hits        17677    17991     +314     
  Misses        261      261              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmlewis]

Thank you, @pucedoteth!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @Not-Dhananjay-Mishra

[Not-Dhananjay-Mishra]

Suggested change

	// Note that packageName is escaped for the URL path so that you don't need to.
	// Note: the packageName is URL path escaped for you. See: https://pkg.go.dev/net/url#PathEscap .

For consistency with rest of the repo.

go-github/github/repos_rules.go

Lines 15 to 22 in 2433615

	// ListRulesForBranch gets all the repository rules that apply to the specified branch.
	//
	// Note: the branch name is URL path escaped for you. See: https://pkg.go.dev/net/url#PathEscape .
	//
	// GitHub API docs: https://docs.github.com/rest/repos/rules?apiVersion=2022-11-28#get-rules-for-a-branch
	//
	//meta:operation GET /repos/{owner}/{repo}/rules/branches/{branch}
	func (s *RepositoriesService) ListRulesForBranch(ctx context.Context, owner, repo, branch string, opts *ListOptions) (*BranchRules, *Response, error) {

Same applies to other occurrences in this PR.

[pucedoteth]

Good catch, thanks — applied to all 8 occurrences in 5d36ebb.

I'd matched orgs_packages.go, the sibling file, but you're right that it's the outlier: repo-wide the // Note: the X name is URL path escaped for you. form appears 55 times across 7 files, against 7 in that one file.

Two small deviations from the literal suggestion, both to match the source you linked:

• The suggested URL ends #PathEscap; I used #PathEscape so the link resolves.
• I used "the package name" rather than "the packageName", matching "the branch name" and "the environment name" in the existing notes.

The result is byte-identical to the repos_rules.go note apart from the noun.