Skip to content

chore: Update SecurityAdvisory structs with new fields #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arraypad wants to merge 1 commit into
base: master
Choose a base branch
from
+121 −0
Open

chore: Update SecurityAdvisory structs with new fields #4413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions github/dependabot_alerts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ type AdvisoryCVSS struct {
VectorString *string `json:"vector_string,omitempty"`
}

// AdvisoryCVSSSeverities represents the advisory pertaining to the Common Vulnerability Scoring System
// for each supported CVSS version.
type AdvisoryCVSSSeverities struct {
CVSSV3 *AdvisoryCVSS `json:"cvss_v3,omitempty"`
CVSSV4 *AdvisoryCVSS `json:"cvss_v4,omitempty"`
}

// AdvisoryCWEs represent the advisory pertaining to Common Weakness Enumeration.
type AdvisoryCWEs struct {
CWEID *string `json:"cwe_id,omitempty"`
Expand All @@ -46,7 +53,9 @@ type DependabotSecurityAdvisory struct {
Description *string `json:"description,omitempty"`
Vulnerabilities []*AdvisoryVulnerability `json:"vulnerabilities,omitempty"`
Severity *string `json:"severity,omitempty"`
Classification *string `json:"classification,omitempty"`
CVSS *AdvisoryCVSS `json:"cvss,omitempty"`
CVSSSeverities *AdvisoryCVSSSeverities `json:"cvss_severities,omitempty"`
CWEs []*AdvisoryCWEs `json:"cwes,omitempty"`
EPSS *AdvisoryEPSS `json:"epss,omitempty"`
Identifiers []*AdvisoryIdentifier `json:"identifiers,omitempty"`
Expand Down
1 change: 1 addition & 0 deletions github/event_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1887,6 +1887,7 @@ type WorkflowRunEvent struct {
// GitHub API docs: https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#security_advisory
type SecurityAdvisory struct {
CVSS *AdvisoryCVSS `json:"cvss,omitempty"`
CVSSSeverities *AdvisoryCVSSSeverities `json:"cvss_severities,omitempty"`
CWEs []*AdvisoryCWEs `json:"cwes,omitempty"`
GHSAID *string `json:"ghsa_id,omitempty"`
Summary *string `json:"summary,omitempty"`
Expand Down
40 changes: 40 additions & 0 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 43 additions & 0 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions github/security_advisories_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,10 @@ func TestListGlobalSecurityAdvisories(t *testing.T) {
"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H",
"score": 7.6
},
"cvss_severities": {
"cvss_v3": {"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H", "score": 7.6},
"cvss_v4": {"vector_string": "CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N", "score": 8.7}
},
"cwes": [
{
"cwe_id": "CWE-400",
Expand Down Expand Up @@ -864,6 +868,16 @@ func TestListGlobalSecurityAdvisories(t *testing.T) {
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
Score: Ptr(7.6),
},
CVSSSeverities: &AdvisoryCVSSSeverities{
CVSSV3: &AdvisoryCVSS{
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
Score: Ptr(7.6),
},
CVSSV4: &AdvisoryCVSS{
VectorString: Ptr("CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N"),
Score: Ptr(8.7),
},
},
CWEs: []*AdvisoryCWEs{
{
CWEID: Ptr("CWE-400"),
Expand Down Expand Up @@ -977,6 +991,10 @@ func TestGetGlobalSecurityAdvisories(t *testing.T) {
"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H",
"score": 7.6
},
"cvss_severities": {
"cvss_v3": {"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H", "score": 7.6},
"cvss_v4": {"vector_string": "CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N", "score": 8.7}
},
"cwes": [
{
"cwe_id": "CWE-400",
Expand Down Expand Up @@ -1044,6 +1062,16 @@ func TestGetGlobalSecurityAdvisories(t *testing.T) {
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
Score: Ptr(7.6),
},
CVSSSeverities: &AdvisoryCVSSSeverities{
CVSSV3: &AdvisoryCVSS{
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
Score: Ptr(7.6),
},
CVSSV4: &AdvisoryCVSS{
VectorString: Ptr("CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N"),
Score: Ptr(8.7),
},
},
CWEs: []*AdvisoryCWEs{
{
CWEID: Ptr("CWE-400"),
Expand Down
Loading