Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -1652,10 +1652,17 @@ func (r *AbuseRateLimitError) Is(target error) bool {
}

return r.Message == v.Message &&
r.RetryAfter == v.RetryAfter &&
equalDurationPtr(r.RetryAfter, v.RetryAfter) &&
compareHTTPResponse(r.Response, v.Response)
}

func equalDurationPtr(a, b *time.Duration) bool {
if a == nil || b == nil {
return a == b
}
return *a == *b
}

// RedirectionError represents a response that returned a redirect status code:
//
// 301 (Moved Permanently)
Expand Down
31 changes: 31 additions & 0 deletions github/github_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3865,6 +3865,37 @@ func TestAbuseRateLimitError_Is(t *testing.T) {
err: err,
otherError: errors.New("github"),
},
"errors are same - RetryAfter equal value but distinct pointers": {
wantSame: true,
err: err,
otherError: &AbuseRateLimitError{
Response: &http.Response{},
Message: "Github",
RetryAfter: &t1,
},
},
"errors are same - RetryAfter both nil": {
wantSame: true,
err: &AbuseRateLimitError{
Response: &http.Response{},
Message: "Github",
RetryAfter: nil,
},
otherError: &AbuseRateLimitError{
Response: &http.Response{},
Message: "Github",
RetryAfter: nil,
},
},
"errors differ - one RetryAfter nil, other non-nil": {
wantSame: false,
err: err,
otherError: &AbuseRateLimitError{
Response: &http.Response{},
Message: "Github",
RetryAfter: nil,
},
},
}

for name, tc := range testcases {
Expand Down
Loading