cmp: guard AllowUnexported against nil arguments - #405
Open
rootkiller6788 wants to merge 2 commits into
Open
rootkiller6788 wants to merge 2 commits into
rootkiller6788 wants to merge 2 commits into
Conversation
Passing a bare nil to AllowUnexported used to panic with a runtime nil pointer dereference from reflect.Type.Kind, instead of the descriptive "invalid struct type" panic every other invalid input gets. Check for a nil type before reading its kind, like cmpopts does in the same situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AllowUnexported is the one option constructor that didn't handle a bare nil. cmp.AllowUnexported(nil) used to die with a runtime nil pointer dereference ("invalid memory address or nil pointer dereference") deep inside reflect.Type.Kind, instead of the "invalid struct type: " panic that every other invalid input already gets. cmpopts.IgnoreTypes and friends nil-check in exactly this spot.
The change adds the missing t == nil check to the existing guard in AllowUnexported, and a small regression test covers the nil case.
One test note: TestOptionPanic can't reach this input because it invokes the option functions through reflection, which has no way to represent a bare nil argument. So the new test calls AllowUnexported(nil) directly and checks the panic message.