Use gtl::fixed_flat_map_of to manage the mapping between AttentionImpl enum values and their string names, simplifying GetAttentionImplName function. Add a test to ensure all valid AttentionImpl enums have a corresponding name and can be looked up.#844
Open
copybara-service[bot] wants to merge 1 commit intodevfrom
Open
Use gtl::fixed_flat_map_of to manage the mapping between AttentionImpl enum values and their string names, simplifying GetAttentionImplName function. Add a test to ensure all valid AttentionImpl enums have a corresponding name and can be looked up.#844copybara-service[bot] wants to merge 1 commit intodevfrom
gtl::fixed_flat_map_of to manage the mapping between AttentionImpl enum values and their string names, simplifying GetAttentionImplName function. Add a test to ensure all valid AttentionImpl enums have a corresponding name and can be looked up.#844copybara-service[bot] wants to merge 1 commit intodevfrom
Conversation
…Impl` enum values and their string names, simplifying `GetAttentionImplName` function. Add a test to ensure all valid `AttentionImpl` enums have a corresponding name and can be looked up. PiperOrigin-RevId: 875204584
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
gtl::fixed_flat_map_ofto manage the mapping betweenAttentionImplenum values and their string names, simplifyingGetAttentionImplNamefunction. Add a test to ensure all validAttentionImplenums have a corresponding name and can be looked up.