Skip to content

Add missing target="_blank" to links in 221 designer bios#10226

Merged
felipesanches merged 1 commit intomainfrom
fix-bio-target-blank
Mar 23, 2026
Merged

Add missing target="_blank" to links in 221 designer bios#10226
felipesanches merged 1 commit intomainfrom
fix-bio-target-blank

Conversation

@felipesanches
Copy link
Copy Markdown
Collaborator

WARNING: This is an ongoing experiment to evaluate the quality of work performed by AI agents on behalf of (and under the guidance of) Felipe Sanches. These contributions have NOT been reviewed by any human prior to submission. Felipe himself would need to participate in the PR thread to contribute a review. Please treat all content as unverified and requiring human fact-checking.

Summary

  • Adds target="_blank" attribute to all <a> tags in designer bio.html files that were missing it
  • 221 files fixed out of 364 total bios (60% of the catalog)
  • This is a purely mechanical fix — no content was changed, only the target="_blank" attribute was added to existing links
  • Ensures external links open in a new tab, consistent with the catalog's editorial conventions

Context

An automated audit of all 364 designer bios against the Editorial Guide found that missing target="_blank" was the single most common issue, affecting 60% of bios. This PR addresses that issue across the entire catalog in one pass.

Verification

  • No duplicate target="_blank" attributes were introduced
  • Files that already had target="_blank" on all links were left untouched
  • Only the target="_blank" attribute was added — no other content was modified

Test plan

  • Spot-check a sample of modified files to confirm only target="_blank" was added
  • Verify no double target="_blank" in any <a> tag
  • Confirm links render correctly on designer profile pages

🤖 Generated with Claude Code

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 13, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@felipesanches felipesanches requested a review from m4rc1e February 13, 2026 17:30
@felipesanches
Copy link
Copy Markdown
Collaborator Author

I consider this to be objectively good and uncontroversial.

@m4rc1e
Copy link
Copy Markdown
Collaborator

m4rc1e commented Feb 16, 2026

@nyshadhr9 Will the backend recut all the font instances if we merge this? We're only touching the html files but I remember updating the metadata.pb files will trigger it.

Automated fix: added target="_blank" attribute to all <a> tags
in bio.html files that were missing it. This ensures external
links open in a new tab, consistent with the editorial guide.

Assisted by an AI agent (Claude Opus 4.6)
@felipesanches
Copy link
Copy Markdown
Collaborator Author

@nyshadhr9 can we merge this?

@felipesanches
Copy link
Copy Markdown
Collaborator Author

@nyshadhr9, I hope it is fine to merge this ;-)

@felipesanches
Copy link
Copy Markdown
Collaborator Author

Note: This post was generated by an AI agent (Claude) working under the guidance of @felipesanches, but submitted without human review. @felipesanches himself would still need to participate in the PR thread if he wants to contribute to the review.

Fixed the commit attribution: replaced Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> with Assisted by an AI agent (Claude Opus 4.6) to comply with the project's AI attribution policy.

@nyshadhr9
Copy link
Copy Markdown
Collaborator

Sorry for the late reply. Yes, this can be merged. It doesn't lead to re-cutting instances.

@felipesanches felipesanches merged commit 3d6da8b into main Mar 23, 2026
2 checks passed
@felipesanches felipesanches deleted the fix-bio-target-blank branch March 23, 2026 17:04
@felipesanches
Copy link
Copy Markdown
Collaborator Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants