[C++] Reset ParseJson field stack between documents - #9241
Open
Parcifalix00 wants to merge 1 commit into
Open
Parcifalix00 wants to merge 1 commit into
Parcifalix00 wants to merge 1 commit into
Conversation
Clear temporary field_stack_ state before parsing each independent JSON document and add a regression test for failed-vector parser reuse.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parser::ParseJson()clearsbuilder_before parsing a new JSON document, butdoes not clear
field_stack_.If malformed JSON causes vector parsing to return early, temporary entries can
remain in
field_stack_. Reusing the sameParserfor subsequent independentParseJson()calls can therefore accumulate parser state across documents.This change clears
field_stack_at the same independent-document boundary asbuilder_.Regression test
The regression test reuses one
Parseracross malformed JSON vector parses andverifies that temporary
field_stack_entries do not accumulate across calls.It also verifies that a subsequent valid JSON document leaves the stack empty.
The identical test fails on the previous implementation and passes with this
change.
Impact
Long-lived integrations that recover from JSON parse errors and reuse a
Parsercan otherwise retain temporary state across independent inputs. Withrepeated malformed inputs this can produce cumulative process-memory growth and,
under a finite memory budget, eventual resource exhaustion.
This change addresses parser-state retention and availability/resource
exhaustion. It does not claim memory corruption, confidentiality or integrity
impact, privilege escalation, or code execution.
Validation
git diff --check: clean.