Replace potentially unsupported use of multiline CMake generator expressions - #9192
Open
maddouri wants to merge 1 commit into
Open
Conversation
…ons with if/endif blocks
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating the project's CMake configuration for an unrelated issue, I noticed several instances of multiline generator expressions.
Based on my reading of the CMake documentation, this appears to be an unsupported form of syntax: relevant part of the generator expressions doc
This PR replaces these multiline generator expressions with equivalent forms:
if()/endif()blocks.I am not entirely sure why the current CMake files appear to work as they are, or why these multiline generator expressions do not seem to trigger any syntax errors. It is possible that the current behavior relies on subtle details of CMake's parser or other implementation-specific behavior. This change avoids relying on behavior that may not be guaranteed by the documented syntax.
If my interpretation of the CMake documentation is incorrect and multiline generator expressions are actually supported, please feel free to close this PR.