Skip to content

Replace potentially unsupported use of multiline CMake generator expressions - #9192

Open
maddouri wants to merge 1 commit into
google:masterfrom
maddouri:fix.invalid_cmake_generator_expression_multiline_syntax
Open

Replace potentially unsupported use of multiline CMake generator expressions#9192
maddouri wants to merge 1 commit into
google:masterfrom
maddouri:fix.invalid_cmake_generator_expression_multiline_syntax

Conversation

@maddouri

@maddouri maddouri commented Aug 1, 2026

Copy link
Copy Markdown

While investigating the project's CMake configuration for an unrelated issue, I noticed several instances of multiline generator expressions.

Based on my reading of the CMake documentation, this appears to be an unsupported form of syntax: relevant part of the generator expressions doc

image

This PR replaces these multiline generator expressions with equivalent forms:

  • Single-line generator expressions.
  • if()/endif() blocks.

I am not entirely sure why the current CMake files appear to work as they are, or why these multiline generator expressions do not seem to trigger any syntax errors. It is possible that the current behavior relies on subtle details of CMake's parser or other implementation-specific behavior. This change avoids relying on behavior that may not be guaranteed by the documented syntax.

If my interpretation of the CMake documentation is incorrect and multiline generator expressions are actually supported, please feel free to close this PR.

@maddouri
maddouri requested a review from dbaileychess as a code owner August 1, 2026 02:57
@google-cla

google-cla Bot commented Aug 1, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant