Fix flaky flexbuffers_alloc_check test in cargo test#8965
Open
RenzoMXD wants to merge 1 commit intogoogle:masterfrom
Open
Fix flaky flexbuffers_alloc_check test in cargo test#8965RenzoMXD wants to merge 1 commit intogoogle:masterfrom
RenzoMXD wants to merge 1 commit intogoogle:masterfrom
Conversation
Collaborator
|
Just to make sure I understand your comment, these tests are executed as part of a PR build elsewhere? What is the use of this file? Thank you for all your help :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alloc check binaries use a global non-thread-safe allocation counter (static mut NUM_ALLOCS) to assert zero heap allocations on warm builder reuse.
When run via
cargo test, the test harness's background threads occasionally allocate, inflating the counter and causing intermittent assertion failures. These binaries are already run reliably viacargo run --binin RustTest.sh, so disabling them as test targets avoids the flaky behavior with no loss of coverage.Closes #8961