[Swarming] Add backpressure mechanism to SwarmingService#5284
Draft
IvanBM18 wants to merge 9 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a backpressure mechanism in
SwarmingServiceto prevent overloading the Swarming pool with too many tasks.Changes
MAX_PENDING_TASKS = 50to limit the number of pending tasks.create_utask_main_jobsto check the queue size before pushing each task using Swarming'sCountTasksRPC.CountTasksrpc call fails, we assume the queue is full and stop scheduling further tasks in the batch.Note
This PR is dependant on this other PR so please go ahead and review that one first :D