Open
Conversation
IvanBM18
added
the
swarming
IvanBM18
commented
Mar 30, 2026
| def is_swarming_task(job_name: str, job: data_types.Job | None = None) -> bool: | ||
| """Returns True if the task is supposed to run on swarming.""" | ||
| if not FeatureFlags.SWARMING_REMOTE_EXECUTION.enabled: | ||
| logs.info('[DEBUG] Flag is disabled', job_name=job_name) |
Collaborator
Author
There was a problem hiding this comment.
Note: Theres no debug severity level in the logs module. I tried adding it but to the logs were not being shown in the GCP log explorer, i guessed thats why didn't had said severity level in the first place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding back the last batch of the changes that were rollbacked which make sure that we weren't making a lot of unnecessary calls into the DB. By consequence the signature of multiple methods were changed to simplified.
I also added a new tests to avoid the previous issue (the one that caused the rollback) from ever appearing again. This tests are in its own test class and its purpose is to check that the BadConfigError is correctly handled when no config is found(which is the expected bahaviour in the external and google envs)
Tests performed in
devenvironmentThis changes have been present since March 25th. Its been over one week since then and metrics seem consistent
Note: Down times in fuzzing hours matches when we deployed a change into the env.
Also no new error groups seem to be appearing in swarming, the only notable error is one relating missing permissions for uploading a test case, which seems unrelated
This changes have been in
devfor quite some time and we have successfully tested their functionality without compromising any functionality. For example this Task was scheduled with this changes.