Use job default arguments when checking for bad builds.#5219
Open
backes wants to merge 1 commit intogoogle:masterfrom
Open
Use job default arguments when checking for bad builds.#5219backes wants to merge 1 commit intogoogle:masterfrom
backes wants to merge 1 commit intogoogle:masterfrom
Conversation
This should allow regression and progression tasks to finish successfully if the issue is reproduced by a specific flag combination rather than an input, and thus even reproduces on an empty input file. See https://crbug.com/495818765 and https://crbug.com/490450921 for examples where this would have been useful.
Collaborator
|
/gcbrun |
| blob_name=blob_name, | ||
| stacktrace_upload_url=blob_upload_url) | ||
| # Setup testcase and its dependencies. | ||
| if uworker_env is not None: |
Collaborator
There was a problem hiding this comment.
nit: I think we can assume uworker_env is never None. Similarly to how was done in regression task.
|
|
||
| data_handler.update_testcase_comment(testcase, data_types.TaskState.STARTED) | ||
|
|
||
| job_app_args = data_handler.get_value_from_job_definition( |
Collaborator
There was a problem hiding this comment.
Nit: could we maybe move this into a centralized method in setup or testcase_manager (e.g. set_default_app_args(job_type, uworker_env))?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow regression and progression tasks to finish successfully if the issue is reproduced by a specific flag combination rather than an input, and thus even reproduces on an empty input file.
See https://crbug.com/495818765 and https://crbug.com/490450921 for examples where this would have been useful.