Fix path traversal: contain template path within the workspace#92
Open
Forbiddem wants to merge 1 commit into
Open
Fix path traversal: contain template path within the workspace#92Forbiddem wants to merge 1 commit into
Forbiddem wants to merge 1 commit into
Conversation
resolveTemplatePath() passed the `@@x-template` field of an .arb file
(and `arb-dir` / `template-arb-file` from l10n.yaml) straight to
fs.readFileSync without any containment check. Both values come from
workspace content, so a crafted repository could set e.g.
"@@x-template": "../../../../etc/passwd"
(or an absolute path) and make the extension read any file the editing
user can open, outside the project root. JSON-with-string-values targets
additionally have their top-level keys echoed into the Problems panel via
the "Missing messages from template" diagnostic.
Resolve the candidate path and reject anything that escapes the workspace
folder (falling back to the document's own directory when there is no
workspace folder). Legitimate in-project templates are unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91.
Problem
Parser.resolveTemplatePath()builds the template path from workspace-controlled content — the@@x-templatefield of an.arbfile, orarb-dir/template-arb-fileinl10n.yaml— andparseAndDecorate()passes it straight tofs.readFileSync(src/messageParser.ts:243). There is no..rejection and no workspace containment, and absolute paths are returned as-is. A crafted repository can therefore read any file the editing user can open, e.g.:{ "@@locale": "es", "@@x-template": "../../../../../../../../../../etc/passwd" }For JSON-with-string-values targets, the file's top-level keys are then echoed into the Problems panel via the
Missing messages from templatediagnostic.Fix
Resolve the candidate path and reject anything that escapes the workspace folder, falling back to the edited document's own directory when there is no workspace folder. Both the
@@x-templatebranch and thel10n.yamlbranch now flow through the same containment check, so legitimate in-project templates keep working while escapes returnundefined(no read).Testing
npm run compile— passesnpm run lint— passeswith_x-template,arb-dir_template-arb-file,template-arb-file) all resolve inside the test workspace, so they remain unaffected by the containment check.I was not able to run the VS Code integration test suite in my environment (it downloads a VS Code build); please run
npm testin CI to confirm.