cuttlefish-integration-gigabyte-arm64: install openjdk by default#2249
Open
grandpaul wants to merge 1 commit intogoogle:mainfrom
Open
cuttlefish-integration-gigabyte-arm64: install openjdk by default#2249grandpaul wants to merge 1 commit intogoogle:mainfrom
grandpaul wants to merge 1 commit intogoogle:mainfrom
Conversation
We've already migrate Gigabyte Ampere server installer to Trixie. Thus we can install openjdk-21 from the repo. Install it by default. We also add modify the tests to check that the openjdk is installed and is the version we want. Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
grandpaul
force-pushed
the
paulliu-install-openjdk-21-trixie
branch
from
438d2b6 to
cc70943
Compare
rmuthiah
approved these changes
Mar 11, 2026
0405ysj
reviewed
Mar 12, 2026
| - name: Test Java version | ||
| run: | | ||
| sshpass -p cuttlefish ssh -o "StrictHostKeyChecking no" -o "UserKnownHostsFile /dev/null" -p 33322 vsoc-01@localhost 'java --version' | ||
| sshpass -p cuttlefish ssh -o "StrictHostKeyChecking no" -o "UserKnownHostsFile /dev/null" -p 33322 vsoc-01@localhost 'java --version' | grep 21.0 |
Collaborator
There was a problem hiding this comment.
What if downloaded version of default-jdk from apt repository is higher than 21.0? If it's okay, what about adding default-jdk (>=2:1.21) on debian/control?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've already migrate Gigabyte Ampere server installer to Trixie. Thus we can install openjdk-21 from the repo. Install it by default.
We also add modify the tests to check that the openjdk is installed and is the version we want.