test(a2a): cover input_required and auth_required as non-terminal states - #7215
Open
vishal-bulbule wants to merge 1 commit into
Open
vishal-bulbule wants to merge 1 commit into
vishal-bulbule wants to merge 1 commit into
Conversation
The skip_summarization tests for converted A2A tasks checked only submitted and working as non-terminal states. Add input_required and auth_required, which pause a task for the user and must not mark the converted event as a final response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
This is the follow-up test a maintainer asked for in
#6872:
"input_required and auth_required still aren't covered by tests, so a small pull request for
those is welcome."
Problem:
aef3a9c set
skip_summarizationfor terminal A2A task states (completed, failed, canceled).The tests for non-terminal states covered only
submittedandworking, so nothing checkedthat
input_requiredandauth_required, which pause a task for the user, do not mark theconverted event as a final response.
Solution:
Add
TS_INPUT_REQUIREDandTS_AUTH_REQUIREDto the existingtest_convert_a2a_task_to_event_non_terminal_state_does_not_set_skip_summarizationparametrization in both
tests/unittests/a2a/converters/test_to_adk.pyandtests/unittests/a2a/converters/test_event_converter.py. Test-only change.Testing Plan
Unit Tests:
The new cases pass on
main, and fail if either state is treated as terminal into_adk_event.py/event_converter.py(checked by temporarily adding them to the terminalset):
The one failing test below,
test_import_loading.py::test_entry_point_loads_only_allowlisted_packages[agent],also fails on
main(d57c84f) and is unrelated to this change; #7214 fixes it.Manual End-to-End (E2E) Tests:
N/A, test-only change.
Checklist