Skip to content

fix(optimization): treat explicit empty eval case ID lists as empty in LocalEvalSampler #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chelsealong wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

fix(optimization): treat explicit empty eval case ID lists as empty in LocalEvalSampler #7170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/google/adk/optimization/local_eval_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,14 @@ def __init__(
self._train_eval_set = self._config.train_eval_set
self._train_eval_case_ids = (
self._config.train_eval_case_ids
or self._get_eval_case_ids(self._train_eval_set)
if self._config.train_eval_case_ids is not None
else self._get_eval_case_ids(self._train_eval_set)
)

self._validation_eval_set = (
self._config.validation_eval_set or self._train_eval_set
)
if self._config.validation_eval_case_ids:
if self._config.validation_eval_case_ids is not None:
self._validation_eval_case_ids = self._config.validation_eval_case_ids
elif self._config.validation_eval_set:
self._validation_eval_case_ids = self._get_eval_case_ids(
Expand Down
17 changes: 17 additions & 0 deletions tests/unittests/optimization/local_eval_sampler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,23 @@ def test_extract_single_invocation_info():
"_validation_eval_case_ids": ["v1"],
},
),
(
{"train_eval_set": "train_set", "train_eval_case_ids": []},
{
"_train_eval_case_ids": [],
"_validation_eval_case_ids": [],
},
),
(
{
"train_eval_set": "train_set",
"validation_eval_case_ids": [],
},
{
"_train_eval_case_ids": ["train_set_1", "train_set_2"],
"_validation_eval_case_ids": [],
},
),
],
)
def test_local_eval_service_interface_init(
Expand Down
Loading