Stop interpolating release analyzer workflow inputs into shell commands#5272
Open
petrmarinec wants to merge 1 commit intogoogle:mainfrom
Open
Stop interpolating release analyzer workflow inputs into shell commands#5272petrmarinec wants to merge 1 commit intogoogle:mainfrom
petrmarinec wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The release analyzer workflow interpolated
workflow_dispatchstring inputs directly into the shell command used inrun:. That let shell metacharacters instart_tagorend_tagbe parsed by bash before Python started.Solution:
Move the dispatch inputs into environment variables and build the Python argument list in bash using an array before invoking the analyzer. This keeps the input values as data instead of shell syntax.
Testing Plan
Unit Tests:
There is no repo unit-test harness for this workflow YAML.
Manual Validation:
python -m adk_release_analyzer.main --start-tag v1.0.0; touch /tmp/gh-before-proof #created the proof file.["--start-tag", "v1.0.0; touch /tmp/gh-after-proof #"]Checklist
Additional context
This is a small workflow hardening change intended to remove shell interpretation of
workflow_dispatchstring inputs while preserving the existing analyzer behavior.