test(a2a): align ResponseConverter tests with unlabelled DataPart fallback - #1405
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_959656099
branch
2 times, most recently
from
August 5, 2026 19:09
5568e30 to
0ae02a4
Compare
…lback A DataPart carrying no `adk_type` metadata is no longer inferred to be a function call. PartConverter serializes it into an inline `text/plain` JSON blob instead, so two tests that still asserted the old inferred behaviour failed at head with `NoSuchElementException` on an empty `functionCall()`. Update both to assert what the converter actually produces: no function call, and an inline JSON blob that still carries the original payload. A small `inlineJson` helper holds the blob-shape assertions and explains why the fallback happens. PiperOrigin-RevId: 959800614
copybara-service
Bot
force-pushed
the
test_959656099
branch
from
August 5, 2026 19:17
0ae02a4 to
cfcec61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(a2a): align ResponseConverter tests with unlabelled DataPart fallback
A DataPart carrying no
adk_typemetadata is no longer inferred to be afunction call. PartConverter serializes it into an inline
text/plainJSONblob instead, so two tests that still asserted the old inferred behaviour
failed at head with
NoSuchElementExceptionon an emptyfunctionCall().Update both to assert what the converter actually produces: no function
call, and an inline JSON blob that still carries the original payload. A
small
inlineJsonhelper holds the blob-shape assertions and explains whythe fallback happens.