fix: add missing await to create_session calls in callback examples#1976
Merged
koverholt merged 2 commits intoJul 20, 2026
Merged
Conversation
InMemorySessionService.create_session is async, so calls without await return unawaited coroutines and the sessions are never created, causing SessionNotFoundError on subsequent runner.run_async() calls.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
koverholt
approved these changes
Jul 20, 2026
koverholt
left a comment
koverholt
left a comment
Collaborator
There was a problem hiding this comment.
Good catch, thanks for contributing this fix, which would cause a SessionNotFoundError. I verified the fix against the latest ADK Python SDK. LGTM, merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InMemorySessionService.create_session is async def, but the before_agent_callback.py and after_agent_callback.py examples call it without await. This returns an unawaited coroutine — the session is never created, and subsequent runner.run_async() fails with SessionNotFoundError.
Fixed by adding await to both create_session calls in both files.