docs(bqaa): document ADK Java preview-readiness fixes (pause/resume tracing, drop stats, redaction)#1975
docs(bqaa): document ADK Java preview-readiness fixes (pause/resume tracing, drop stats, redaction)#1975caohy1988 wants to merge 4 commits into
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Review against current The Java-specific direction is good, and most behavioral claims check out. I found two blockers and three smaller documentation gaps before this is ready to publish. Blocking
Additional gaps
Verified as correct
Once the branch is rebuilt on current main and the eight-reason contract is fixed, the release-gating approach looks good for the next Java tag. |
Covers google/adk-java@c685ece46b (redaction, table bootstrap, drop stats) and google/adk-java@2027a4b53d (tracing, lifecycle, redaction, HITL/TOOL_PAUSED pairing), rebuilt on current main and gated as post-v1.6.0 until the next adk-java release is tagged: - Top note gating the new Java behavior, with a TODO(publish) marker. - ADK 2.0 section: Java emits TOOL_PAUSED and the pause/resume pairing keys at the top level of attributes (no attributes.adk envelope), without AGENT_TRANSFER / AGENT_STATE_CHECKPOINT / EVENT_COMPACTION; Java variant of the base-table pairing query; HITL completions carry the same top-level pair keys for direct base-table joins. - Views footnote: Java creates v_tool_paused and the pause columns on v_tool_completed only; the three workflow views are Python-only. - Dropped-event observability: Java getDropStats() with all eight drop reasons (queue_full, append_error, serialization_error, after_close, shutdown_timeout, writer_permit_exhausted, writer_create_error, late_after_finalize). - Built-in redaction: Java redacts the six sensitive keys plus temp: (not secret:); contentFormatter contract (thread-safe, non-blocking, no mutation) and fail-closed behavior. - Tracing: Java ID-only span tracking; trace_id wording no longer claims 32-hex absolutely — Java falls back to the ADK invocation ID. - Public methods (Java): getDropStats() and the JVM shutdown-hook drain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b1f10df to
478c32a
Compare
|
All five points addressed in 478c32a (branch rebuilt, force-pushed):
Still draft pending the next adk-java tag; all gating phrasings are greppable via 🤖 Generated with Claude Code |
|
Fresh review of Findings
Verified in this pass
|
- Closing guidance: any non-zero drop counter is actual loss, not risk; alert on every reason, with queue_full / write-error counts called out as throughput or Storage Write health signals. - Java append_error: broaden the definition to match BatchProcessor — any batch-preparation or append failure other than AppendSerializationError (timeouts, exhausted or non-retryable writes, unexpected conversion failures). - TODO(publish) marker: on release, delete the preview admonition and convert gated sections to section-level language-support-tag Java chips per PR google#1942, instead of keeping prose version callouts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
All three findings addressed in fe5adff:
🤖 Generated with Claude Code |
adk-java v1.7.0 (2026-07-20) ships the July preview-readiness fixes; verified no agentanalytics changes between the reviewed commit ba23601c and the v1.7.0 tag. Per the publish checklist: - Delete the preview 'ADK Java version requirement' admonition and its TODO(publish) marker. - Add the 'Java v1.7.0' language-support chip to the ADK 2.0 workflow section (PR google#1942 convention). - Convert the inline 'builds newer than v1.6.0' callouts to v1.7.0 version references throughout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
adk-java v1.7.0 (2026-07-20) is out and ships both preview-readiness commits — verified there are no Publish checklist executed in ba107cf:
Marked the PR ready for review. Remaining: the stale three-reason 🤖 Generated with Claude Code |
Summary
Documents the ADK Java BQAA "preview-readiness fixes" — shipped in adk-java
v1.7.0(released 2026-07-20) — in the BigQuery Agent Analytics page:TOOL_PAUSEDpairingAll behavioral claims were verified against the plugin source (
BigQueryAgentAnalyticsPlugin,BigQueryLoggerConfig,BigQueryUtils,JsonFormatter,PluginState,BatchProcessor,TraceManager); the reviewed commitba23601chas noagentanalyticsdiffs against thev1.7.0tag.What changed
Java v1.7.0language-support chip added (per the Enhance BigQuery Agent Analytics with new options #1942 convention). Java emitsTOOL_PAUSEDand the pause/resume pairing keys, but storespause_kind/function_call_idat the top level ofattributes(noattributes.adkenvelope, which is Python-only), and does not emitAGENT_TRANSFER/AGENT_STATE_CHECKPOINT/EVENT_COMPACTION. Includes the Java variant of the base-table pairing query, and notes thatHITL_*_REQUEST_COMPLETEDrows carry the same top-level pair keys (no dedicated HITL-completion view).v_tool_pausedand the pause columns onv_tool_completed; the three workflow views are Python-only.getDropStats()with all eight drop reasons (queue_full,append_error,serialization_error,after_close,shutdown_timeout,writer_permit_exhausted,writer_create_error,late_after_finalize);append_errordefined per theBatchProcessorcontract (any batch-prep/append failure other thanAppendSerializationError); tabbed code samples; closing guidance treats any non-zero counter as actual loss.temp:-prefixed keys — but notsecret:(Python-only). JavacontentFormattercontract documented (thread-safe, fast/non-blocking, return a new object) plus fail-closed behavior on exceptions.trace_idis a 32-char OTel ID when inherited from an ambient span; Python generates that format as its fallback, while Java falls back to the ADK invocation ID.getDropStats()and the JVM shutdown hook that drains pending events at exit whenclose()was never called.Review feedback addressed
main; eight-reasongetDropStats()contract; softened 32-hextrace_idwording; HITL completion pair keys;contentFormattercontract.append_errorbroadened to matchBatchProcessor; publish plan switched to Enhance BigQuery Agent Analytics with new options #1942-style version chips.Publish checklist
v1.7.0, 2026-07-20)TODO(publish)comment deleted; gated sections converted to the section-levellanguage-support-tagconvention (Java v1.7.0chip on the ADK 2.0 section); all inline "builds newer thanv1.6.0" prose replaced with v1.7.0 referencesgetDropStats()reason keys and top-levelpause_kind/function_call_idattribute location re-verified against the tag (noagentanalyticschanges betweenba23601candv1.7.0)BigQueryAgentAnalyticsPlugin.getDropStats()upstream in adk-java (tracked separately, per review)🤖 Generated with Claude Code