Add GULMulticastUserNotificationCenterDelegate#71
Open
charlotteliang wants to merge 2 commits intochar-multicast-featurefrom
Open
Add GULMulticastUserNotificationCenterDelegate#71charlotteliang wants to merge 2 commits intochar-multicast-featurefrom
charlotteliang wants to merge 2 commits intochar-multicast-featurefrom
Conversation
Coverage Report 1Affected ProductsNo changes between base commit (8c4fcf6) and merge commit (68e2244).Test Logs |
paulb777
reviewed
Feb 17, 2022
Member
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
Are unit tests needed?
Even if not, there should still be a pod lib lint build test added to CI
| } | ||
|
|
||
| + (id<GULMulticastNotificationProtocol>)multicastDelegate { | ||
| if (@available(iOS 10.0, *)) { |
Member
There was a problem hiding this comment.
Why not an API_AVAILABLE(ios(10.0) on the api instead?
|
|
||
| #import "GoogleUtilitiesMulticastAppDelegate/Sources/Public/GoogleUtilities/GULMulticastAppDelegate.h" | ||
| #import <GoogleUtilitiesMulticastAppDelegate/GULMulticastAppDelegate.h> | ||
| //#import <GoogleUtilities/GULAppDelegateSwizzler.h> |
fuzailvigo
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GULMulticastUserNotificationCenterDelegate to cast delegate methods from UNUserNotificationCenter used by Messaging to handle notification open and foreground tracking in Analytics.