Skip to content

Carry nonce and claimsAsJSON through Device Policy flows - #637

Merged
w-goog merged 5 commits into
mainfrom
feature/continuation-options-carry
Sep 21, 2026
Merged

w-goog merged 5 commits into
mainfrom
feature/continuation-options-carry

Conversation

@w-goog

@w-goog w-goog commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

optionsWithExtraParameters:forContinuation: didn't manually copy these parameters when the flow was being resumed. While this required quite a setup to occur, it's a nice fix.

Also, I made a helper method for the tests, because DRY, ya know.

@w-goog
w-goog requested a review from mdmathias September 9, 2026 21:10
Comment thread GoogleSignIn/Tests/Unit/GIDSignInInternalOptionsTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInInternalOptionsTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInInternalOptionsTest.m Outdated
@brnnmrls
brnnmrls force-pushed the feature/continuation-options-carry branch from 73e34c6 to 8964917 Compare September 21, 2026 18:14
@w-goog
w-goog merged commit c983faa into main Sep 21, 2026
27 checks passed
@w-goog
w-goog deleted the feature/continuation-options-carry branch September 21, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants